Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): improve decimal aggregate state #16983

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Dec 2, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

https://blog.rust-lang.org/2024/03/30/i128-layout-update.html

align of i128 has been changed from 8 to 16 bytes which increases the allocated state size.

This pr make decimal state stored as u64 arrays which keep the align as 8 bytes.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 2, 2024
@sundy-li sundy-li marked this pull request as ready for review December 3, 2024 03:21
@sundy-li sundy-li enabled auto-merge December 3, 2024 12:36
@sundy-li sundy-li added this pull request to the merge queue Dec 3, 2024
Merged via the queue into databendlabs:main with commit 900ecf1 Dec 3, 2024
75 checks passed
@sundy-li sundy-li deleted the decimal-stat branch December 3, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants