Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGR-2976: Add stage to management #2984

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

BohuTANG
Copy link
Member

@BohuTANG BohuTANG commented Nov 23, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Summary about this PR:

  • Add user stage api stored to metasrv,
  • Add stage operations to query/users

this is part of #2976

Changelog

  • New Feature

Related Issues

Fixes #2980

Test Plan

Unit Tests

Stateless Tests

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Nov 23, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@BohuTANG BohuTANG changed the title MGR-2976: Add stage MGR-2976: Add stage to management Nov 23, 2021
@BohuTANG BohuTANG requested a review from sundy-li November 23, 2021 11:19
@BohuTANG BohuTANG marked this pull request as draft November 23, 2021 11:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #2984 (8730cb5) into main (9695869) will increase coverage by 0%.
The diff coverage is 94%.

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #2984    +/-   ##
======================================
  Coverage     68%     68%            
======================================
  Files        644     648     +4     
  Lines      33880   34007   +127     
======================================
+ Hits       23062   23158    +96     
- Misses     10818   10849    +31     
Impacted Files Coverage Δ
common/meta/types/src/user_stage.rs 50% <50%> (ø)
query/src/users/user_stage.rs 90% <90%> (ø)
common/management/src/stage/stage_mgr.rs 94% <94%> (ø)
query/src/users/user_stage_test.rs 97% <97%> (ø)
common/management/src/user/user_mgr.rs 95% <100%> (ø)
query/src/users/user_mgr.rs 83% <100%> (-1%) ⬇️
query/src/common/mod.rs 70% <0%> (-15%) ⬇️
query/src/clusters/cluster.rs 54% <0%> (-2%) ⬇️
query/src/sql/statements/statement_select.rs 85% <0%> (+<1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9695869...8730cb5. Read the comment docs.

@BohuTANG BohuTANG force-pushed the dev-stage-metasrv-2976 branch from f4b55df to 8730cb5 Compare November 23, 2021 12:22
@BohuTANG BohuTANG marked this pull request as ready for review November 23, 2021 12:22
@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG BohuTANG merged commit 3526d5e into databendlabs:main Nov 23, 2021
@BohuTANG BohuTANG deleted the dev-stage-metasrv-2976 branch November 23, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common/management supports write <tenant_id/stage_name, stage_path> key-value pair to metasrv
4 participants