Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] try to add sharedkey and resetkey #3687

Merged
merged 4 commits into from
Dec 29, 2021
Merged

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Dec 29, 2021

Signed-off-by: Chojan Shang psiace@outlook.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

try to add sharedkey and resetkey

  • sharedkey an additional key that is stable over multiple jobs.
  • resetkey use v* to control the cache version. If we need to reset the cache version, increment the number after v.

Changelog

  • Build/Testing/CI
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE PsiACE requested a review from Xuanwo December 29, 2021 02:54
@databend-bot databend-bot added pr-build this PR changes build/testing/ci steps pr-not-for-changelog labels Dec 29, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

2 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/5Wr3dJdCLMgUPY3956GyTEwE2g4f
✅ Preview: Canceled

[Deployment for 836377c canceled]

Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #3687 (836377c) into main (b712e6d) will increase coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3687   +/-   ##
=====================================
  Coverage     60%     60%           
=====================================
  Files        697     697           
  Lines      37230   37230           
=====================================
+ Hits       22367   22381   +14     
+ Misses     14863   14849   -14     
Impacted Files Coverage Δ
...pelines/transforms/transform_aggregator_partial.rs 86% <0%> (-2%) ⬇️
metasrv/src/meta_service/raftmeta.rs 47% <0%> (+<1%) ⬆️
common/datavalues/src/data_field.rs 71% <0%> (+<1%) ⬆️
common/meta/sled-store/src/sled_tree.rs 91% <0%> (+1%) ⬆️
query/src/storages/fuse/statistics/accumulator.rs 86% <0%> (+1%) ⬆️
common/management/src/cluster/cluster_mgr.rs 80% <0%> (+1%) ⬆️
common/dal/src/context.rs 74% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b712e6d...836377c. Read the comment docs.

@sundy-li sundy-li merged commit 1b6bf39 into databendlabs:main Dec 29, 2021
@PsiACE PsiACE deleted the reset-cache branch January 10, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants