Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dal2: Implement limited & offset reader for fs and s3 #3985

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 25, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fixed #3937

Changelog

  • New Feature

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from BohuTANG as a code owner January 25, 2022 06:55
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Jan 25, 2022
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@PsiACE
Copy link
Member

PsiACE commented Jan 25, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2022

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@vercel
Copy link

vercel bot commented Jan 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/CDHfm4ccMejGAByC5uKZfCxbiuDp
✅ Preview: https://databend-git-fork-xuanwo-limitedreader-databend.vercel.app

@codecov-commenter
Copy link

Codecov Report

Merging #3985 (af2c0b5) into main (3c2bc7d) will increase coverage by 0%.
The diff coverage is 75%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3985   +/-   ##
=====================================
  Coverage     57%     57%           
=====================================
  Files        803     803           
  Lines      42988   43003   +15     
=====================================
+ Hits       24548   24561   +13     
- Misses     18440   18442    +2     
Impacted Files Coverage Δ
common/dal2/src/services/s3.rs 68% <ø> (ø)
common/dal2/src/ops/io.rs 85% <75%> (-2%) ⬇️
common/dal2/src/services/fs.rs 76% <75%> (-1%) ⬇️
common/dal/src/context.rs 86% <0%> (-2%) ⬇️
metasrv/src/meta_service/raftmeta.rs 48% <0%> (-1%) ⬇️
query/src/clusters/cluster.rs 41% <0%> (+<1%) ⬆️
...pelines/transforms/transform_aggregator_partial.rs 88% <0%> (+1%) ⬆️
common/management/src/cluster/cluster_mgr.rs 80% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2bc7d...af2c0b5. Read the comment docs.

@dantengsky
Copy link
Member

/lgtm

@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG BohuTANG merged commit c77fb3d into databendlabs:main Jan 25, 2022
@Xuanwo Xuanwo deleted the limited_reader branch February 12, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dal2: Implement LimitedReader
6 participants