Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dal2: Implement DAL Layer support #4067

Merged
merged 4 commits into from
Feb 7, 2022
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 7, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Part of #3677

This PR add layer (interceptor) support for DAL.

Changelog

  • New Feature

Test Plan

Unit Tests

Stateless Tests

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from BohuTANG as a code owner February 7, 2022 09:54
@databend-bot databend-bot added pr-feature this PR introduces a new feature to the codebase labels Feb 7, 2022
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/4uD3K9vvS9AtECYquNGyv2Kj7jDF
✅ Preview: https://databend-git-fork-xuanwo-dal2-databend.vercel.app

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@BohuTANG
Copy link
Member

BohuTANG commented Feb 7, 2022

/lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #4067 (6d2d2eb) into main (c9f8bbf) will decrease coverage by 0%.
The diff coverage is 20%.

❗ Current head 6d2d2eb differs from pull request most recent head 6ea64e5. Consider uploading reports for the commit 6ea64e5 to get more accurate results

Impacted file tree graph

@@          Coverage Diff           @@
##            main   #4067    +/-   ##
======================================
- Coverage     57%     57%    -1%     
======================================
  Files        828     830     +2     
  Lines      44195   44352   +157     
======================================
+ Hits       25444   25463    +19     
- Misses     18751   18889   +138     
Impacted Files Coverage Δ
common/dal2/src/accessor.rs 0% <0%> (ø)
common/dal2/src/operator.rs 100% <ø> (ø)
common/dal2/src/layer.rs 16% <100%> (ø)
common/containers/src/pool.rs 77% <0%> (-3%) ⬇️
common/dal/src/context.rs 86% <0%> (-3%) ⬇️
common/management/src/cluster/cluster_mgr.rs 77% <0%> (-1%) ⬇️
metasrv/src/meta_service/raftmeta.rs 48% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d916ec...6ea64e5. Read the comment docs.

@databend-bot
Copy link
Member

Wait for another reviewer approval

Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@databend-bot
Copy link
Member

CI Passed
Reviewers Approved
Let's Merge
Thank you for the PR @Xuanwo

@databend-bot databend-bot merged commit 72cde46 into databendlabs:main Feb 7, 2022
@Xuanwo Xuanwo deleted the dal2 branch February 7, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants