Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dal2: Implement Context support #4069

Merged
merged 6 commits into from
Feb 8, 2022
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Feb 8, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Part of #3677

This PR implements a DAL Context which will implement Layer and Accessor.

Changelog

  • New Feature

Test Plan

Unit Tests

Stateless Tests

@Xuanwo Xuanwo requested a review from BohuTANG as a code owner February 8, 2022 05:26
@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Feb 8, 2022
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

1 similar comment
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/5qoRqdhKBmGewpZSYcAfCeELVkdg
✅ Preview: Canceled

[Deployment for e8ee2c8 canceled]

@Xuanwo Xuanwo changed the title Dal context dal2: Implement Context support Feb 8, 2022
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

Codecov Report

Merging #4069 (df98dc2) into main (396fcae) will decrease coverage by 0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4069   +/-   ##
=====================================
- Coverage     57%     57%   -1%     
=====================================
  Files        829     829           
  Lines      44231   44231           
=====================================
- Hits       25537   25533    -4     
- Misses     18694   18698    +4     
Impacted Files Coverage Δ
common/dal2/src/accessor.rs 0% <ø> (ø)
common/dal2/src/ops/stat.rs 77% <ø> (ø)
common/dal2/src/services/fs.rs 82% <ø> (ø)
common/dal2/src/services/s3.rs 22% <ø> (ø)
common/management/src/cluster/cluster_mgr.rs 77% <0%> (-3%) ⬇️
metasrv/src/network.rs 97% <0%> (-2%) ⬇️
metasrv/src/meta_service/meta_service_impl.rs 92% <0%> (-2%) ⬇️
metasrv/src/meta_service/raftmeta.rs 48% <0%> (-1%) ⬇️
common/dal/src/context.rs 88% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 396fcae...df98dc2. Read the comment docs.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Veeupup
Copy link
Contributor

Veeupup commented Feb 8, 2022

/LGTM

@BohuTANG
Copy link
Member

BohuTANG commented Feb 8, 2022

/lgtm

@mergify mergify bot merged commit d70ad52 into databendlabs:main Feb 8, 2022
@Xuanwo Xuanwo deleted the dal_context branch February 8, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants