-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add state machine range and subscribe API #4608
Feature: add state machine range and subscribe API #4608
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/FWxLPa2NLSSmjcMZtaDhZctyyjSG [Deployment for 281b5b2 canceled] |
Thanks for the contribution! Please review the labels and make any necessary changes. |
Why do we need range APIs for meta datas? |
in etcd watch API, see https://etcd.io/docs/v3.2/learning/api/#watch-api, they have the key range:
|
On the doc page: If several given events happened as the following:
A watch request for key range |
I wonder if or not return the current event at the first time when a watcher has created, but in etcd doc and code, seems they do not return event when create watcher.ok, i delete the range API. |
Feature: add state machine range and subscribe API Feature: remove unused comment
…bend into add_sm_range_subscribe_api
@lichuang |
1 similar comment
@lichuang |
ready |
The range APIs are still there. BTW, another issue is that range-API is not snapshot-based. The result may be inconsistent. |
sad, when rebase source it does not remove the range API... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Feature: add state machine range and subscribe API
Changelog
Related Issues
Fixes #issue #4607
Test Plan
Unit Tests
Stateless Tests