feature: support REGEXP_INSTR function #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/HgaUerMJ4bSr6opFWYGPqQwXtF51 |
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
pr-feature
nange
changed the title
sundy-li
reviewed
Mar 30, 2022
|
|
||
| let iter = izip!(source, pos, occur, ro); | ||
| for (s_value, pos_value, occur_value, ro_value) in iter { | ||
| if ro_value != 0 && ro_value != 1 { |
There was a problem hiding this comment.
Since it's constant column, so we don't need to check this inside the loop?
Just use let v = column.as_u64()? to check the value.
sundy-li
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Changelog
Related Issues
Fixes #3069
Test Plan
Unit Tests
Stateless Tests