Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(function): Const(Nullable(Object)) column downcast to Nullable failed #4733

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Apr 7, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

If the column is Const(Nullable(Object)), it will panic when downcast to Nullable(Object) column.

There is one more issue to be concerned about. The column data type returned by the storage is a little different. If the engine is FUSE, it will return the Nullable column, but if the engine is Memory, it will return the Const Nullable column.

Changelog

  • Bug Fix

Related Issues

#4684

@vercel
Copy link

vercel bot commented Apr 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/4Yt5q3YaP3ySCndN1bgHHGRn57V4
✅ Preview: https://databend-git-fork-b41sh-fix-const-nullable-databend.vercel.app

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants