Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Watch api #4779

Merged
merged 29 commits into from
Apr 16, 2022
Merged

Feature: Watch api #4779

merged 29 commits into from
Apr 16, 2022

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Apr 9, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. add watch API for metasrv
  2. add unit tests for watch API.

Changelog

  • New Feature

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Apr 9, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/5a69zviicKyWUM14SRsnWQGLJVSz
✅ Preview: https://databend-git-fork-lichuang-watchapi-databend.vercel.app

[Deployment for 4f2c28c canceled]

@lichuang lichuang requested review from drmingdrmer and ariesdevil and removed request for drmingdrmer April 9, 2022 14:02
@mergify
Copy link
Contributor

mergify bot commented Apr 9, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Apr 9, 2022
drmingdrmer
drmingdrmer reviewed Apr 9, 2022
View reviewed changes
common/meta/raft-store/src/state_machine/sm.rs Outdated Show resolved Hide resolved
common/meta/types/proto/meta.proto Outdated Show resolved Hide resolved
common/meta/types/proto/meta.proto Outdated Show resolved Hide resolved
common/meta/raft-store/src/state_machine/sm.rs Outdated Show resolved Hide resolved
common/meta/types/proto/meta.proto Outdated Show resolved Hide resolved
drmingdrmer
drmingdrmer reviewed Apr 11, 2022
View reviewed changes
common/meta/types/proto/meta.proto Outdated Show resolved Hide resolved
metasrv/src/watcher/watcher_stream.rs Outdated Show resolved Hide resolved
metasrv/src/watcher/watcher_config.rs Outdated Show resolved Hide resolved
common/meta/types/proto/meta.proto Outdated Show resolved Hide resolved
@lichuang lichuang requested a review from BohuTANG as a code owner April 14, 2022 11:23
drmingdrmer
drmingdrmer reviewed Apr 14, 2022
View reviewed changes
metasrv/src/watcher/watcher_manager.rs Outdated Show resolved Hide resolved
metasrv/src/watcher/watcher_manager.rs Outdated Show resolved Hide resolved
metasrv/src/watcher/watcher_manager.rs Outdated Show resolved Hide resolved
metasrv/src/watcher/watcher_manager.rs Outdated Show resolved Hide resolved
metasrv/tests/it/grpc/metasrv_grpc_watch.rs Outdated Show resolved Hide resolved
metasrv/tests/it/grpc/metasrv_grpc_watch.rs Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Apr 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Apr 16, 2022 at 6:59AM (UTC)

ariesdevil
ariesdevil approved these changes Apr 16, 2022
View reviewed changes
Copy link
Contributor

@ariesdevil ariesdevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and after this PR merged we need a simple doc that let the cloud team know how to use this feature.

@drmingdrmer
Copy link
Member

/lgtm

trump-lgtm

@mergify mergify bot merged commit 41069c9 into databendlabs:main Apr 16, 2022
@BohuTANG
Copy link
Member

The API adds/remove will be a compatible problem with old databend-metasrv?
If so, how the user upgrade the old databend-metasrv to the new? There is already some users using databend in the production now 💯
cc @lichuang @drmingdrmer

@drmingdrmer
Copy link
Member

The API adds/remove will be a compatible problem with old databend-metasrv? If so, how the user upgrade the old databend-metasrv to the new? There is already some users using databend in the production now 💯 cc @lichuang @drmingdrmer

This feature does not affect data format thus the upgrade would be smooth:)

@BohuTANG BohuTANG mentioned this pull request Apr 30, 2022
Closed
3 tasks
@lichuang lichuang deleted the watch_api branch May 14, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@databend-bot databend-bot databend-bot approved these changes

@ariesdevil ariesdevil ariesdevil approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@drmingdrmer drmingdrmer Awaiting requested review from drmingdrmer

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lichuang @drmingdrmer @BohuTANG @ariesdevil @databend-bot