fix(mysql_handler): salt characters should be ascii. #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/BkrQZBp17sFhuctfsCYEiuZQjtxV |
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
BohuTANG
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
lgtm 💯
I have fixed a same issue for clickhouse years ago:
https://github.com/ClickHouse/ClickHouse/blob/dd0d3de05005aee10d901ac6324851a625d5d61b/src/Core/MySQL/Authentication.cpp#L46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
passwordCharacterEncoding is utf8mb4 by default https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-connp-props-connection.html#cj-conn-prop_passwordCharacterEncoding
code refer to
https://github.com/mysql/mysql-server/blob/3290a66c89eb1625a7058e0ef732432b6952b435/mysys/crypt_genhash_impl.cc#L421
current opensrv impl make sure salt followed by "\0"
Changelog
Related Issues
Fixes #4802