-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support substring #487
support substring #487
Conversation
04b54de
to
78ce427
Compare
from: args[1].clone(), | ||
len: args[2].clone() | ||
})), | ||
_ => Result::Err(ErrorCodes::BadArguments(format!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need format here, just use to_string()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
15a0315
to
d39a89d
Compare
@tlightsky Hi, is there any way add a substring test to performance suites? |
@BohuTANG
|
8d62558
to
de41b90
Compare
just rebased, and the performance test seems failed on this branch:
|
Try to change the |
removed 2 zero for all and the tests can finish after 41s |
took 46s on MacBook Pro
|
Hi, this patch almost done.
Performance tests are used to anchor to a fixed amount of data(normal case is 100bllion, and slow case such as GroupBy is 1000000000) and then see if there is performance degradation, it's mainly for the github CI. |
PR: |
cool, |
Revert performance tests data size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @tlightsky
Summary
support substring
Changelog
Related Issues
#429
Test Plan
unit tests