compatibility mysql insert and select #4883

TCeason · 2022-04-16T06:13:50Z

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

compatibility double quoted for MySQL:

insert into t values("xxx");
show tables where table_name like "";
show databases where name like "";
select "";
select * from t where name = "";
select * from t2 where id in ("1");
select * from t2 where c between "" and "";
select * from t2 where id like "";

Changelog

Improvement
Build/Testing/CI

Related Issues

Fixes #4861 #1551

vercel · 2022-04-16T06:13:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
databend	✅ Ready (Inspect)	Visit Preview	Apr 17, 2022 at 1:51AM (UTC)

mergify · 2022-04-16T06:14:23Z

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

BohuTANG · 2022-04-16T08:39:32Z

The error is:

Traceback (most recent call last):
  File "/workspace/tests/suites/0_stateless/10_drivers/10_0000_python_clickhouse_driver.py", line 6, in <module>
    from clickhouse_driver import connect
ModuleNotFoundError: No module named 'clickhouse_driver'

For new setup tools, we should open a PR for clickhouse_driver first, then merge to this PR after main branch docker build finished, there is a demo(install sqlalchemy module a few days ago) : #4775

databendlabs#4883 (comment)

BohuTANG · 2022-04-16T10:00:48Z

@mergify update

mergify · 2022-04-16T10:01:06Z

update

✅ Branch has been successfully updated

BohuTANG · 2022-04-16T10:04:12Z

tools/fuzz/fuzz_targets/fuzz_parse_sql.rs

 use databend_query::sql::DfParser;
 use honggfuzz::fuzz;

 fn main() {
    loop {
        fuzz!(|data: String| {
-            let _ = DfParser::parse_sql(&data);
+            let _ = DfParser::parse_sql(&data, SessionType::Fuzz);


Hmm, how to run fuzz?

Actually, I also have some issues with this file. I'm not sure why we need this file. And can not find where it is used.

To build success, I add a new SessionType Fuzz.

Hi @PsiACE Are we using this for testing now? And how can I use it for databend query?

Fuzz type is not necessary, I think it makes more sense to use it for fuzz testing of existing session types. As for how to run the fuzz test, you can see https://github.com/datafuselabs/databend/blob/main/tools/fuzz/README.md

It is not integrated in CI for now, and I am not sure if there are plans to use it to improve our parser. We have introduced the fuzz test in #700. It has helped us in the past to make some small improvements to the parser or the upstream sqlparser.

query/src/sql/statements/analyzer_value_expr.rs

BohuTANG · 2022-04-16T10:22:15Z

query/src/sql/sql_parser.rs

-        Ok(result)
+    pub fn parse_sql(
+        sql: &'a str,
+        typ: SessionType,


If databend default sql dialect is MySqlDialect, the problems is?

Then we no need a SessionType there

If use ClickHouse Client connect Databend server or ClickHouse server SQL like

select “number” will return col value

But use MySQL client it will return a string

tests/suites/0_stateless/00_dummy/00_0000_dummy_select_1.sql

like this test

Double quota is not sql standard(not allowed by Snowflake, Pg, ClickHouse), it's just for MySQL...

So we need this special SessionType

query/src/sql/sql_parser.rs

query/src/sql/statements/value_source.rs

b41sh · 2022-04-16T10:26:00Z

tests/suites/0_stateless/03_dml/03_0018_insert_into_variant.sql

@@ -37,7 +37,7 @@ select * from t3;
 select arr[0] from t3;
 select arr[5] from t3;
 select arr[3][0] from t3;
-select arr[4]["k"] from t3;


Do double-quoted strings cause errors?

query/src/sql/sql_parser.rs

compatibility double quoted for MySQL: ``` insert into t values("xxx"); select * from t where col="xxx"; ```

BohuTANG · 2022-04-17T01:44:44Z

Tips:
When the PR review starts, please don't use force-pushed, because it loses a lot of information and the reviewer doesn't know what was changed from the last change.

BohuTANG

lgtm

TCeason requested a review from BohuTANG as a code owner April 16, 2022 06:13

databend-bot added the need-review label Apr 16, 2022

vercel bot temporarily deployed to Preview April 16, 2022 06:13 Inactive

mergify bot added pr-improvement pr-build this PR changes build/testing/ci steps labels Apr 16, 2022

TCeason force-pushed the ISSUE-4861/compatibility_mysql_select branch from 499ea9a to baea4ec Compare April 16, 2022 07:45

vercel bot temporarily deployed to Preview April 16, 2022 07:45 Inactive

BohuTANG requested a review from sundy-li April 16, 2022 08:34

TCeason added a commit to TCeason/datafuse that referenced this pull request Apr 16, 2022

chore(ci): add clickhouse_driver to dev_setup

70e9405

databendlabs#4883 (comment)

TCeason mentioned this pull request Apr 16, 2022

feature:How to add a new dev set? #4886

Closed

vercel bot temporarily deployed to Preview April 16, 2022 10:01 Inactive

BohuTANG reviewed Apr 16, 2022

View reviewed changes

BohuTANG requested a review from b41sh April 16, 2022 10:04

BohuTANG reviewed Apr 16, 2022

View reviewed changes

query/src/sql/statements/analyzer_value_expr.rs Show resolved Hide resolved

BohuTANG reviewed Apr 16, 2022

View reviewed changes

b41sh reviewed Apr 16, 2022

View reviewed changes

TCeason force-pushed the ISSUE-4861/compatibility_mysql_select branch from 391e891 to 11c1772 Compare April 16, 2022 10:34

vercel bot temporarily deployed to Preview April 16, 2022 10:34 Inactive

TCeason force-pushed the ISSUE-4861/compatibility_mysql_select branch from 11c1772 to ea57906 Compare April 16, 2022 10:36

vercel bot temporarily deployed to Preview April 16, 2022 10:36 Inactive

TCeason force-pushed the ISSUE-4861/compatibility_mysql_select branch from ea57906 to 87870ed Compare April 16, 2022 11:23

vercel bot temporarily deployed to Preview April 16, 2022 11:24 Inactive

TCeason force-pushed the ISSUE-4861/compatibility_mysql_select branch from 87870ed to d8a7802 Compare April 16, 2022 11:25

vercel bot temporarily deployed to Preview April 16, 2022 11:25 Inactive

sundy-li approved these changes Apr 16, 2022

View reviewed changes

BohuTANG reviewed Apr 16, 2022

View reviewed changes

query/src/sql/sql_parser.rs Outdated Show resolved Hide resolved

compatibility mysql insert and select

2f95750

compatibility double quoted for MySQL: ``` insert into t values("xxx"); select * from t where col="xxx"; ```

TCeason force-pushed the ISSUE-4861/compatibility_mysql_select branch from d8a7802 to 2f95750 Compare April 17, 2022 01:36

vercel bot temporarily deployed to Preview April 17, 2022 01:36 Inactive

BohuTANG approved these changes Apr 17, 2022

View reviewed changes

Merge branch 'main' into ISSUE-4861/compatibility_mysql_select

4760780

vercel bot deployed to Preview April 17, 2022 01:50 View deployment

mergify bot merged commit f8e4cc3 into databendlabs:main Apr 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compatibility mysql insert and select #4883

compatibility mysql insert and select #4883

TCeason commented Apr 16, 2022 •

edited

Loading

vercel bot commented Apr 16, 2022 •

edited

Loading

mergify bot commented Apr 16, 2022

BohuTANG commented Apr 16, 2022 •

edited

Loading

BohuTANG commented Apr 16, 2022

mergify bot commented Apr 16, 2022

BohuTANG Apr 16, 2022

TCeason Apr 16, 2022

TCeason Apr 17, 2022

PsiACE Apr 17, 2022

BohuTANG Apr 16, 2022

BohuTANG Apr 16, 2022 •

edited

Loading

TCeason Apr 16, 2022

TCeason Apr 16, 2022

sundy-li Apr 16, 2022

b41sh Apr 16, 2022

BohuTANG commented Apr 17, 2022 •

edited

Loading

BohuTANG left a comment

compatibility mysql insert and select #4883

compatibility mysql insert and select #4883

Conversation

TCeason commented Apr 16, 2022 • edited Loading

Summary

Changelog

Related Issues

vercel bot commented Apr 16, 2022 • edited Loading

mergify bot commented Apr 16, 2022

BohuTANG commented Apr 16, 2022 • edited Loading

BohuTANG commented Apr 16, 2022

mergify bot commented Apr 16, 2022

✅ Branch has been successfully updated

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BohuTANG Apr 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BohuTANG commented Apr 17, 2022 • edited Loading

BohuTANG left a comment

Choose a reason for hiding this comment

TCeason commented Apr 16, 2022 •

edited

Loading

vercel bot commented Apr 16, 2022 •

edited

Loading

BohuTANG commented Apr 16, 2022 •

edited

Loading

BohuTANG Apr 16, 2022 •

edited

Loading

BohuTANG commented Apr 17, 2022 •

edited

Loading