chore(mysql): fix mysql empty query #4889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
cadl
reviewed
Apr 17, 2022
There was a problem hiding this comment.
Found one related unit-test case tests/it/servers/http/clickhouse_handler.rs#50l should be changed.
| @@ -0,0 +1 @@ | |||
| 0 | |||
There was a problem hiding this comment.
How about adding one test statement before /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;?
/*!40101*/select number from numbers_mt(2);
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101*/select number from numbers_mt(1);
and check
0
1
0
Maybe we can be more sure where is the empty line.
There was a problem hiding this comment.
👍
This draft PR only for test, found some test issues, still would like you can push a new PR for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
fix mysql empty query
Changelog
Related Issues
Fixes #4860