Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(group): fix group by with negative value #4902

Merged
merged 6 commits into from
Apr 18, 2022

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Apr 18, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fixes(group): fix group by with negative value

Changelog

  • Bug Fix

Related Issues

Fixes #4891

@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Apr 18, 2022 at 4:04AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 18, 2022
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sundy-li
Copy link
Member

--- /workspace/tests/suites/0_stateless/11_data_type/11_0000_data_type_numeric.result 2022-04-18 01:18:43.518211757 +0000
+++ /workspace/tests/suites/0_stateless/11_data_type/11_0000_data_type_numeric.stdout 2022-04-18 01:22:32.499905245 +0000
@@ -1,3 +1,4 @@
-1 255
+-1
127 255
-128 0

@zhang2014
Copy link
Member Author

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2022

update

✅ Branch has been successfully updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group by not work for negative
4 participants