feat(data type): implement PartialOrd for Variant data-type #4959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
pr-feature
b41sh
force-pushed
the
variant-PartialOrd
branch
from
86c81dd
to
f473a41
Compare
sundy-li
reviewed
Apr 21, 2022
| use serde_json::Value; | ||
|
|
||
| #[derive(serde::Serialize, serde::Deserialize, Debug, Clone, PartialEq, Eq)] | ||
| pub struct VariantValue(Value); |
There was a problem hiding this comment.
Better to put this struct same level as DataValue.
sundy-li
reviewed
Apr 21, 2022
| } | ||
|
|
||
| // VariantValue compares as the following rule: | ||
| // Null > Array > Object > String > Number > Boolean |
There was a problem hiding this comment.
So we can give each struct a level value.
If the level is not equal, compare the level value.
There was a problem hiding this comment.
do you mean add a level filed in struct VariantValue?
There was a problem hiding this comment.
fn level(&self) -> u8 {
match ...
}
sundy-li
reviewed
Apr 21, 2022
| (Value::Object(_), Value::Null) => Ordering::Less, | ||
| (Value::Object(_), Value::Array(_)) => Ordering::Less, | ||
| (Value::Object(o1), Value::Object(o2)) => { | ||
| for (k1, k2) in o1.keys().zip(o2.keys()) { |
There was a problem hiding this comment.
yes, keys are iterated in alphabetical order.
sundy-li
approved these changes
Apr 21, 2022
sundy-li
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
VariantValueas a wrapper ofserde_json::ValuePartialOrdforVariantValueJsonColumnasVariantColumnDataValue::JsonasDataValue::VariantChangelog
Related Issues
Fixes #4903