Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parser): switch to the new sql parser #4983

Merged
merged 3 commits into from
Apr 21, 2022
Merged

feat(parser): switch to the new sql parser #4983

merged 3 commits into from
Apr 21, 2022

Conversation

andylokandy
Copy link
Collaborator

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Let the new planner use the new SQL parser
  • Throw away the SQL transformer, an adaptor for sqlparser-rs

Changelog

  • New Feature

Related Issues

@vercel
Copy link

vercel bot commented Apr 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 21, 2022 at 7:42AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Apr 21, 2022
leiysky
leiysky approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BohuTANG BohuTANG merged commit 0ac1c2c into databendlabs:main Apr 21, 2022
@leiysky leiysky mentioned this pull request May 13, 2022
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky approved these changes

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andylokandy @leiysky @BohuTANG @databend-bot