feature(types): function in support other datatypes #5011
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
the
pr-feature
| } | ||
| TypeID::DateTime => { | ||
| scalar_contains!(i64, input_col, input_rows, columns, least_super_dt); | ||
| } | ||
| _ => { | ||
| unimplemented!() |
There was a problem hiding this comment.
Better to return error instead of the unimplemented panic.
There was a problem hiding this comment.
yes, i will open a new pr to fix it.
There was a problem hiding this comment.
Great, seems some unimplemented both in the common/functions and common/datavalues.
There was a problem hiding this comment.
Yes, because there are some judges before and the program can't reach unimplementd. But I think return error seems better.
| { | ||
| true => columns[0].field().data_type().clone(), | ||
| false => { | ||
| return Result::Err(ErrorCode::BadDataValueType("test")); |
There was a problem hiding this comment.
I forget to change the err info and i will fix it in a new pr together.
| match columns[1..] | ||
| .iter() | ||
| .map(|column| column.field().data_type().data_type_id()) | ||
| .all(|t| t.is_string() || t.is_date_or_date_time()) |
There was a problem hiding this comment.
I find some bugs just now. The TypeID may be nullable. I will fix it.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
function in support datatypes
Changelog
Related Issues
Fixes #4995