Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix doc parser #5088

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix doc parser #5088

merged 1 commit into from
Apr 28, 2022

Conversation

jiahuizz
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix doc parser.

Changelog

  • Bug Fix

When I fix #4615, PR: #4843,

I find that the regular expression can't match titles with spaces such as "not like", "not regexp".

And the regular expression also can't match multiple titles. For example, in docs/doc/30-reference/20-functions/30-datetime-functions/addinterval.md, there is a line like "title_includes: addYears, addMonths, addDays, addHours, addMinutes, addSeconds", the regular expression can't match the space between "addYears," and "addMonths", so the parse result is not right.

Related Issues

Fixes #4615

@vercel
Copy link

vercel bot commented Apr 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Apr 28, 2022 at 9:27AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Apr 28, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Apr 28, 2022
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution @jiahui-97 !

@BohuTANG BohuTANG merged commit 4076980 into databendlabs:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add category for some functions
4 participants