-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(planner): Implement hash inner join #5175
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
query/src/pipelines/new/processors/transforms/hash_join/hash.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
// Copyright 2022 Datafuse Labs. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use std::hash::Hasher; | ||
|
||
use common_datavalues::ColumnRef; | ||
use common_datavalues::ColumnWithField; | ||
use common_datavalues::DataField; | ||
use common_datavalues::PrimitiveColumn; | ||
use common_datavalues::Series; | ||
use common_exception::Result; | ||
use common_functions::scalars::FunctionContext; | ||
use common_functions::scalars::FunctionFactory; | ||
use twox_hash::XxHash64; | ||
|
||
pub type HashVector = Vec<u64>; | ||
|
||
pub struct HashUtil; | ||
|
||
impl HashUtil { | ||
pub fn compute_hash(column: &ColumnRef) -> Result<HashVector> { | ||
let hash_function = FunctionFactory::instance().get("xxhash64", &[&column.data_type()])?; | ||
let field = DataField::new("", column.data_type()); | ||
let result = hash_function.eval( | ||
FunctionContext::default(), | ||
&[ColumnWithField::new(column.clone(), field)], | ||
column.len(), | ||
)?; | ||
|
||
let result = Series::remove_nullable(&result); | ||
let result = Series::check_get::<PrimitiveColumn<u64>>(&result)?; | ||
Ok(result.values().to_vec()) | ||
} | ||
|
||
pub fn combine_hashes(inputs: &[HashVector], size: usize) -> HashVector { | ||
static XXHASH_SEED: u64 = 0; | ||
|
||
let mut result = Vec::with_capacity(size); | ||
result.resize(size, XxHash64::with_seed(XXHASH_SEED)); | ||
for input in inputs.iter() { | ||
assert_eq!(input.len(), size); | ||
for i in 0..size { | ||
result[i].write_u64(input[i]); | ||
} | ||
} | ||
result.into_iter().map(|h| h.finish()).collect() | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhang2014
I found it's tricky to put the parallel pipelines into a same
NewPipeline
.In current implementation, it would spawn sub-tasks(i.e. building hash table) with
PipelineExecutor
, and spawn root task(i.e. the pipeline which probes hash table) withPipelinePullingExecutor
.The root task will be blocked until the hash table building is finished, which is achieved by polling the state of
HashJoinState
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spawn sub-tasks is ok. I'll work on this task.
We need add NewPipe type(zip nested pipeline last pipe with outer pipeline previous pipe):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhang2014 That's amazing.
I suggest to make
nested_pipeline
aVec<NewPipeline>
, so we can support multi-wayUNION
and multi-way join in the future with it.