Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access check for management mode #5211

Merged
merged 1 commit into from
May 7, 2022

Conversation

junnplus
Copy link
Contributor

@junnplus junnplus commented May 7, 2022

Signed-off-by: Ye Sijun junnplus@gmail.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

#5209

Changelog

  • New Feature

Related Issues

Fixes #5209

Signed-off-by: Ye Sijun <junnplus@gmail.com>
@vercel
Copy link

vercel bot commented May 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 7, 2022 at 7:56AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 7, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 7, 2022
@BohuTANG
Copy link
Member

BohuTANG commented May 7, 2022

Have a question:
Where will we use the management mode?

@junnplus
Copy link
Contributor Author

junnplus commented May 7, 2022

Have a question: Where will we use the management mode?

@BohuTANG If the user does not have the query service (warehouse), we need to forward some management SQL to the manage service(management mode) on the gateway.

@BohuTANG BohuTANG merged commit 4075557 into databendlabs:main May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add access check for management mode
3 participants