Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-5019: re-reorganization the common crates #5233

Merged
merged 1 commit into from
May 8, 2022

Conversation

usamoi
Copy link
Contributor

@usamoi usamoi commented May 8, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Merges common-mem-allocator, common-containers and common-range-map to common-base.

Changelog

Not for changelog

Related Issues

Closes #5019.

@vercel
Copy link

vercel bot commented May 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 8, 2022 at 9:19AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 8, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@@ -0,0 +1,40 @@
mod format;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to add the copyright :D

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .idea directory.

@usamoi
Copy link
Contributor Author

usamoi commented May 8, 2022

@BohuTANG Sorry. Fixed now.

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A monster PR, love it to make the common crate cleaner.
Great work, thank you for the contribution, @usamoi

@BohuTANG BohuTANG merged commit 35003a9 into databendlabs:main May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider re-reorganization the common crates
3 participants