feat(planner): select without from #5256

Veeupup · 2022-05-09T07:29:25Z

Signed-off-by: Veeupup code@tanweime.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

implement select with from in new planner

Changelog

New Feature

Related Issues

Fixes #5163

Signed-off-by: Veeupup <code@tanweime.com>

vercel · 2022-05-09T07:29:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
databend	⬜️ Ignored (Inspect)		May 9, 2022 at 0:45AM (UTC)

mergify · 2022-05-09T07:29:57Z

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

leiysky

LGTM

leiysky · 2022-05-09T07:33:06Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

@@ -65,4 +65,10 @@ drop table t;
 drop table t1;
 drop table t2;

+-- Select without from


Would you like to add select 'test case kind'; for the test cases above? So the test result can be seperated.

yeah, will be done now

It seems we should split some small tests for v2 in some conflicts PR, name them like 20_0001_planner_v2_select_without_from.sql? cc @leiysky @xudong963

When planner v2 is ready, we can backport and merge them to our other stateless tests.

It seems we should split some small tests for v2 in some conflicts PR, name them like 20_0001_planner_v2_select_without_from.sql? cc @leiysky @xudong963

@BohuTANG This test suite won't exist for too long, we just exploit it to make sure there is no regression of our recent work.

We are running stateless tests with new planner enabled to find out the features we haven't implemented yet. As soon as the new planner can pass all the test suites, this file will be deprecated.

And after migrating to new planner, we are going to migrate the test suites to sqllogic test framework. Which means we won't put more effort on merging this with other tests.

Yes, I think the migration will be completed soon 🐛

query/src/sql/planner/binder/select.rs

Signed-off-by: Veeupup <code@tanweime.com>

BohuTANG · 2022-05-09T10:28:33Z

CI failed:

test parser::test_statements_in_legacy_suites ... FAILED

failures:

---- parser::test_statements_in_legacy_suites stdout ----
thread 'parser::test_statements_in_legacy_suites' panicked at 'called `Result::unwrap()` on an `Err` value: Code: 1005, displayText = error: 
  --> SQL:4:1
  |
1 | set enable_planner_v2 = 1;
2 | 
3 | select '====SELECT_FROM_NUMBERS===='
4 | select * from numbers(10);
  | ^^^^^^ expected `.`, `(`, `IS`, `NOT`, `IN`, `BETWEEN`, or 54 more ...

https://github.com/datafuselabs/databend/runs/6349095598?check_suite_focus=true#step:3:328

How to find CI error, search failed:

leiysky · 2022-05-09T11:05:48Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

@@ -1,23 +1,30 @@
 set enable_planner_v2 = 1;

+select '====SELECT_FROM_NUMBERS===='


Suggested change

select '====SELECT_FROM_NUMBERS===='

select '====SELECT_FROM_NUMBERS====';

leiysky · 2022-05-09T11:06:06Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

 select * from numbers(10);

 -- Comparison expressions
+select '====COMPARSION===='


Suggested change

select '====COMPARSION===='

select '====COMPARSION====';

leiysky · 2022-05-09T11:06:29Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

 select * from numbers(10) where number between 1 and 9 and number > 2 and number < 8 and number is not null and number = 5 and number >= 5 and number <= 5;

 -- Cast expression
+select '====CAST===='


Suggested change

select '====CAST===='

select '====CAST====';

leiysky · 2022-05-09T11:06:46Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

 select * from numbers(10) where cast(number as string) = '5';

 -- Binary operator
+select '====BINARY_OPERATOR===='


Suggested change

select '====BINARY_OPERATOR===='

select '====BINARY_OPERATOR====';

leiysky · 2022-05-09T11:07:14Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

 select (number + 1 - 2) * 3 / 4 from numbers(1);

 -- Functions
+select '====FUNCTIONS===='


Suggested change

select '====FUNCTIONS===='

select '====FUNCTIONS====';

leiysky · 2022-05-09T11:07:41Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

 select sin(cos(number)) from numbers(1);

 -- In list
+select '====IN_LIST===='


Suggested change

select '====IN_LIST===='

select '====IN_LIST====';

leiysky · 2022-05-09T11:07:57Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

 select * from numbers(5) where number in (1, 3);

 -- Aggregator operator
+select '====AGGREGATER===='


Suggested change

select '====AGGREGATER===='

select '====AGGREGATER====';

leiysky · 2022-05-09T11:08:13Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

@@ -45,6 +52,7 @@ SELECT max(number) FROM numbers_mt (10) where number > 99999999998;
 SELECT max(number) FROM numbers_mt (10) where number > 2;

 -- Inner join
+select '====INNER_JOIN===='


Suggested change

select '====INNER_JOIN===='

select '====INNER_JOIN====';

leiysky · 2022-05-09T11:08:35Z

tests/suites/0_stateless/20+_others/20_0001_planner_v2.sql

@@ -67,4 +75,11 @@ drop table t2;

 select count(*) from numbers(1000) as t inner join numbers(1000) as t1 on t.number = t1.number;

+-- Select without from
+select '====SELECT_WITHOUT_FROM===='


Suggested change

select '====SELECT_WITHOUT_FROM===='

select '====SELECT_WITHOUT_FROM====';

Signed-off-by: Xuanwo <github@xuanwo.io>

feat(planner): select with from

1746034

Signed-off-by: Veeupup <code@tanweime.com>

Veeupup requested a review from BohuTANG as a code owner May 9, 2022 07:29

databend-bot added the need-review label May 9, 2022

mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 9, 2022

leiysky changed the title ~~feat(planner): select with from~~ feat(planner): select without from May 9, 2022

leiysky approved these changes May 9, 2022

View reviewed changes

Merge branch 'master' into select_1

7d502b5

Veeupup requested review from sundy-li and xudong963 May 9, 2022 07:31

leiysky reviewed May 9, 2022

View reviewed changes

query/src/sql/planner/binder/select.rs Outdated Show resolved Hide resolved

new test add seperator

bace18e

Signed-off-by: Veeupup <code@tanweime.com>

xudong963 approved these changes May 9, 2022

View reviewed changes

Merge branch 'main' into select_with_from

dc85415

vercel bot deployed to Preview May 9, 2022 08:21 View deployment

Merge branch 'main' into select_with_from

3e51bca

sundy-li approved these changes May 9, 2022

View reviewed changes

leiysky reviewed May 9, 2022

View reviewed changes

feat(scripts/setup): Install jdk

e2332ed

Signed-off-by: Xuanwo <github@xuanwo.io>

Veeupup force-pushed the select_with_from branch from 2b5f844 to e2332ed Compare May 9, 2022 11:34

fix test

6c961b5

Veeupup force-pushed the select_with_from branch from ccdd1f1 to 6c961b5 Compare May 9, 2022 12:05

mergify bot added 2 commits May 9, 2022 12:23

Merge branch 'main' into select_with_from

2cb2063

Merge branch 'main' into select_with_from

4503184

BohuTANG removed their request for review May 9, 2022 12:45

mergify bot merged commit 19a3f7c into databendlabs:main May 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(planner): select without from #5256

feat(planner): select without from #5256

Veeupup commented May 9, 2022

vercel bot commented May 9, 2022 •

edited

Loading

mergify bot commented May 9, 2022

leiysky left a comment

leiysky May 9, 2022

Veeupup May 9, 2022

BohuTANG May 9, 2022

BohuTANG May 9, 2022

leiysky May 9, 2022

xudong963 May 9, 2022

BohuTANG commented May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

leiysky May 9, 2022

		@@ -1,23 +1,30 @@
		set enable_planner_v2 = 1;

		select '====SELECT_FROM_NUMBERS===='

	select '====SELECT_FROM_NUMBERS===='
	select '====SELECT_FROM_NUMBERS====';

	select '====BINARY_OPERATOR===='
	select '====BINARY_OPERATOR====';

	select '====SELECT_WITHOUT_FROM===='
	select '====SELECT_WITHOUT_FROM====';

feat(planner): select without from #5256

feat(planner): select without from #5256

Conversation

Veeupup commented May 9, 2022

Summary

Changelog

Related Issues

vercel bot commented May 9, 2022 • edited Loading

mergify bot commented May 9, 2022

leiysky left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BohuTANG commented May 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented May 9, 2022 •

edited

Loading