feat(planner): support subquery table reference type for new planner #5279
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
the
pr-feature
xudong963
changed the title
| @@ -74,9 +75,17 @@ impl<'a> Binder { | |||
| pub(super) async fn normalize_select_list( | |||
| &mut self, | |||
| select_list: &[SelectTarget<'a>], | |||
| input_context: &BindContext, | |||
| table_alias: &Option<TableAlias<'a>>, | |||
There was a problem hiding this comment.
What happen if this query:
SELECT * FROM system.columns, (SELECT 1) AS `system.columns`;
There was a problem hiding this comment.
Duplicated table names will result in an error.
There was a problem hiding this comment.
`system.table` should not be equal to system.table
There was a problem hiding this comment.
system.tableshould not be equal to system.table
The "system.table" should be parsed into identifier. It won't be an issue.
|
Oops, conflicts need solved |
|
This pull request has merge conflicts that must be resolved before it can be merged. @xudong963 please update it 🙏. Try |
|
Hmm, Conflicting files after another merged. |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
support table reference type: subquery for new planner
Changelog
Related Issues
Fixes #5203