Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(query): introduce meta Runtime" #5300

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented May 11, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Reverts #5294

Changelog

  • Build/Testing/CI

@vercel
Copy link

vercel bot commented May 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 11, 2022 at 9:51AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 11, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-build this PR changes build/testing/ci steps label May 11, 2022
@Xuanwo
Copy link
Member

Xuanwo commented May 11, 2022

I have updated the description to make our friend fusebot happy.

@BohuTANG
Copy link
Member

BohuTANG commented May 11, 2022

The revert reason is the meta-runtime does not work?

@sundy-li
Copy link
Member Author

The revert reason is the meta-runtime does not work?

It works, but it may make the runtime blocked in this sync call. Searching for other ways.

@BohuTANG BohuTANG merged commit 641dd5e into main May 11, 2022
@BohuTANG BohuTANG deleted the revert-5294-meta-runtime branch May 11, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants