Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(functions): make aggregate function sum/avg/min/max support null … #5436

Merged
merged 2 commits into from
May 18, 2022

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented May 18, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Make aggregate function sum/avg/min/max support null type

Changelog

  • Bug Fix

Related Issues

Fixes #5434

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 18, 2022 at 6:41AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 18, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label May 18, 2022
@sundy-li sundy-li requested a review from ZeaLoVe May 18, 2022 05:18
@xudong963
Copy link
Member

Related Issues

Fixes #5432

Seems linked issue doesn't match the pr

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented May 18, 2022

update

✅ Branch has been successfully updated

@BohuTANG BohuTANG merged commit 5e7a56b into databendlabs:main May 18, 2022
@Xuanwo Xuanwo deleted the agg-null branch May 18, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null can't save in query result
4 participants