Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: snapshot timestamp & navigation #5535

Merged
merged 4 commits into from
May 24, 2022
Merged

feat: snapshot timestamp & navigation #5535

merged 4 commits into from
May 24, 2022

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented May 23, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  • Add timestamp field to TableSnapshot
    which is of type Option<DateTime<Utc>>. for legacy table snapshots, it is None
  • Add navigate method to FuseTable
    pub async fn navigate(
        &self,
        ctx: &Arc<QueryContext>,
        time_point: DateTime<Utc>,
    ) -> Result<Arc<FuseTable>>;

Changelog

  • New Feature
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #5514

@vercel
Copy link

vercel bot commented May 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 24, 2022 at 3:54AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 23, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-not-for-changelog labels May 23, 2022
@dantengsky dantengsky changed the title add timestamp to table snapshot feat: snapshot timestamp & nagivation May 24, 2022
@dantengsky dantengsky changed the title feat: snapshot timestamp & nagivation feat: snapshot timestamp & navigation May 24, 2022
@dantengsky dantengsky marked this pull request as ready for review May 24, 2022 05:23
@dantengsky dantengsky requested a review from BohuTANG as a code owner May 24, 2022 05:23
@dantengsky dantengsky requested a review from zhyass May 24, 2022 05:24
@BohuTANG BohuTANG merged commit b1e3cf4 into databendlabs:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@zhyass zhyass Awaiting requested review from zhyass

Assignees

@dantengsky dantengsky

Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
Databend Storage Layer
Status: 📦 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: add timestamp field to table snapshot
3 participants
@dantengsky @BohuTANG @databend-bot