Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving role_cache_manager to session manager #5605

Merged
merged 1 commit into from
May 26, 2022

Conversation

junnplus
Copy link
Contributor

@junnplus junnplus commented May 26, 2022

Signed-off-by: Ye Sijun junnplus@gmail.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

RoleCacheMgr should be a global object. Moving role_cache_manager to session manager.

Changelog

  • Bug Fix

Related Issues

Fixes #5474

Signed-off-by: Ye Sijun <junnplus@gmail.com>
@vercel
Copy link

vercel bot commented May 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 26, 2022 at 7:54AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 26, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label May 26, 2022
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice~

@BohuTANG BohuTANG merged commit 3803591 into databendlabs:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokio task not exists
4 participants