Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add exec permissionn to downloaded binaries #5661

Merged
merged 1 commit into from
May 29, 2022

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented May 29, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

[ci] add exec permission to downloaded binaries

Changelog

Related Issues

@vercel
Copy link

vercel bot commented May 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 29, 2022 at 2:50PM (UTC)

@drmingdrmer drmingdrmer marked this pull request as ready for review May 29, 2022 13:50
@mergify
Copy link
Contributor

mergify bot commented May 29, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer requested a review from Xuanwo May 29, 2022 13:50
@Xuanwo
Copy link
Member

Xuanwo commented May 29, 2022

Please also check the download link is correct. I got a 404 error while trying to download the file.

In log we have: https://github.com/datafuselabs/databend/releases/download/v-nightly/databend-v-nightly-x86_64-unknown-linux-gnu.tar.gz

@drmingdrmer
Copy link
Member Author

Please also check the download link is correct. I got a 404 error while trying to download the file.

In log we have: https://github.com/datafuselabs/databend/releases/download/v-nightly/databend-v-nightly-x86_64-unknown-linux-gnu.tar.gz

It should be correct. The version should not be empty if there was not the
permission error.

https://github.com/datafuselabs/databend/releases/download/v{0.7.63}-nightly/databend-v-nightly-x86_64-unknown-linux-gnu.tar.gz
                                                            --------

@mergify mergify bot merged commit a1c03c6 into databendlabs:main May 29, 2022
@drmingdrmer drmingdrmer deleted the 20-fix-test-compat branch May 29, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants