Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): Fail fast if the underlying storage is not available #5671

Merged
merged 2 commits into from
May 30, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 30, 2022

Signed-off-by: Xuanwo github@xuanwo.io

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

It is possible that our users will have misconfigured storage. They could misspell the endpoint URL, or their K8s config map is not updated, or AWS STS doesn't return the updated token.

This PR will add a check after constructing the OpenDAL operator to know whether the current storage is functional. If not, we will return the error directly instead of keep running.

  • For local setup, users can check their config quicker instead of while they are running queries.
  • For K8S and cloud setup, databend-query will be restarted automatically until all config updated or reach the deadline.

Thanks to the new API Operator::check() introduced in OpenDAL v0.7

There is a demo of users forget to config aws access key:

B21GORawHl

Changelog

  • New Feature

@vercel
Copy link

vercel bot commented May 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) May 30, 2022 at 7:46AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented May 30, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label May 30, 2022
@Xuanwo Xuanwo requested a review from junnplus May 30, 2022 05:45
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from sundy-li May 30, 2022 08:13
@BohuTANG BohuTANG merged commit 5c8d878 into databendlabs:main May 30, 2022
@Xuanwo Xuanwo deleted the fail-fast branch May 30, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants