-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(query): support FixedKey u128, u256, u512 in group query #5678
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
fn aggregate_state(&self) -> Self::State { | ||
Self::State::create((u8::MAX as usize) + 1) | ||
} | ||
macro_rules! dispatch_unsigned_short_types{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use macros? It doesn't seem to reduce the duplicate code for us. Instead, it reduces the code readability(and macros are not modification friendly).
Performance:
|
@@ -214,6 +200,93 @@ impl PolymorphicKeysHelper<HashMethodKeysU64> for HashMethodKeysU64 { | |||
} | |||
} | |||
|
|||
impl PolymorphicKeysHelper<HashMethodKeysU128> for HashMethodKeysU128 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be better to apply macro for u128
, u256
and u512
here. cc@zhang2014
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may be better not to introduce macros if not necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Changelog
Related Issues
Fixes #5630