Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove schema_api_test_suite todos #5690

Merged
merged 1 commit into from
May 30, 2022
Merged

Remove schema_api_test_suite todos #5690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions common/meta/api/src/schema_api_test_suite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,13 +1224,7 @@ impl SchemaApiTestSuite {

let got = mt.get_table((tenant, db1_name, tb3_name).into()).await?;
let want = TableInfo {
// TODO: use this after kv-txn rename-table replaces metasrv rename-table:
// `ident: tb_ident.clone(),`
// rename-table should not change the seq.
ident: TableIdent {
table_id: tb_ident.table_id,
seq: got.ident.seq,
},
ident: tb_ident.clone(),
desc: format!("'{}'.'{}'.'{}'", tenant, db1_name, tb3_name),
name: tb3_name.into(),
meta: table_meta(created_on),
Expand Down Expand Up @@ -1363,12 +1357,7 @@ impl SchemaApiTestSuite {

let got = mt.get_table((tenant, db2_name, tb3_name).into()).await?;
let want = TableInfo {
// TODO similar: version should not change.
// ident: tb_ident2,
ident: TableIdent {
table_id: tb_ident2.table_id,
seq: got.ident.seq,
},
ident: tb_ident2,
desc: format!("'{}'.'{}'.'{}'", tenant, db2_name, tb3_name),
name: tb3_name.into(),
meta: table_meta(created_on),
Expand Down