Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscribe_metrics todos. #5801

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

devillove084
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI
  • Documentation
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Jun 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 6, 2022 at 10:12AM (UTC)

@devillove084 devillove084 changed the title Fix subscribe metrics Remove subscribe_metrics todos. Jun 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-bugfix this PR patches a bug in codebase pr-improvement pr-build this PR changes build/testing/ci steps labels Jun 6, 2022
@devillove084 devillove084 merged commit 9334eb9 into databendlabs:main Jun 6, 2022
@devillove084 devillove084 deleted the fix_subscribe_metrics branch June 6, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase pr-build this PR changes build/testing/ci steps pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants