feat(planner): support drop database in new planner #5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
pr-feature
ygf11
commented
Jun 8, 2022
| @@ -206,10 +203,17 @@ pub struct CreateDatabaseStmt<'a> { | |||
| pub if_not_exists: bool, | |||
| pub catalog: Option<Identifier<'a>>, | |||
| pub database: Identifier<'a>, | |||
| pub engine: DatabaseEngine, | |||
| pub engine: Option<DatabaseEngine>, | |||
There was a problem hiding this comment.
We still need DatabaseEngine::Default to distinguish none-engine and default engine,
because explicitly specifying engine is allowed in planner v1, like:
CREATE DATABASE t engine=default;
cc: @andylokandy
andylokandy
approved these changes
Jun 8, 2022
|
@mergify update |
✅ Branch has been successfully updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Changelog
Related Issues
Fixes #5828
Part of #5775