Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): migrate CreateUDF to planner v2 #5905

Merged
merged 7 commits into from
Jun 28, 2022

Conversation

TennyZhuang
Copy link
Contributor

@TennyZhuang TennyZhuang commented Jun 11, 2022

Signed-off-by: TennyZhuang zty0826@gmail.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

migrate CreateUDF to planner v2

Changelog

  • New Feature
  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #5904

Signed-off-by: TennyZhuang <zty0826@gmail.com>
@vercel
Copy link

vercel bot commented Jun 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 10:18AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 11, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added pr-feature this PR introduces a new feature to the codebase pr-not-for-changelog labels Jun 11, 2022
@BohuTANG BohuTANG requested a review from leiysky June 11, 2022 01:31
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@mergify

This comment was marked as resolved.

@mergify

This comment was marked as off-topic.

@PsiACE PsiACE marked this pull request as draft June 28, 2022 05:10
@Xuanwo Xuanwo marked this pull request as ready for review June 28, 2022 05:47
Signed-off-by: Xuanwo <github@xuanwo.io>
mergify bot added a commit that referenced this pull request Jun 28, 2022
@BohuTANG
Copy link
Member

@Xuanwo Xuanwo marked this pull request as draft June 28, 2022 09:55
mergify bot added a commit that referenced this pull request Jun 28, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

@mergify unqueue

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo marked this pull request as ready for review June 28, 2022 10:09
@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

refresh

✅ Pull request refreshed

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

update

✅ Branch has been successfully updated

@Xuanwo
Copy link
Member

Xuanwo commented Jun 28, 2022

Stateless tests related to the UDF(in the old planner) need to add to the v2 :/ https://github.com/datafuselabs/databend/blob/87f4250119bb69689a6aa060400f70bfd7cc7073/tests/suites/0_stateless/05_ddl/05_0010_ddl_create_udf.sql

Added.

mergify bot added a commit that referenced this pull request Jun 28, 2022
@Xuanwo Xuanwo merged commit f86f295 into databendlabs:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate CREATE FUNCTION statement to new planner #5899
6 participants