-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(planner): corretly handle catalog in statements #5909
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
workspace/tests/suites/0_stateless/05_ddl/05_0003_ddl_alter_database_v2.stdout 2022-06-12 00:30:24.425825160 +0000 |
Is this behavior commonly used in other DBMS ? I thought it's always case-sensitive. |
In most of the databases, the default behaviour is case-insensitive. And the case-sensitivity of identifiers is controled in different ways, for example:
This is work about normalizing the convention of identifiers, which is correlated with #5717 . This PR only makes minor refactor of AST and unifies the behaviour of identifier case handling in new planner. It doesn't aim to resolve the issue of identifier case. I have made an offline discussion with @andylokandy , we decide to get rest work done later. |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
DATABASE
,TABLE
andVIEW
statements.Changelog
Related Issues
Part of #5907