Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(optimizer): Support constant folding #5924

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jun 12, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Support constant folding and filter normalization.

Changelog

  • New Feature

Related Issues

Part of #5919

@vercel
Copy link

vercel bot commented Jun 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 13, 2022 at 4:29AM (UTC)

@leiysky leiysky requested a review from xudong963 June 12, 2022 14:24
@leiysky leiysky added the pr-feature this PR introduces a new feature to the codebase label Jun 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a case in the pr but got stack overflow:

mysql> select * from t1 where a > 0 or false;
ERROR 2013 (HY000): Lost connection to MySQL server during query
No connection. Trying to reconnect...
ERROR 2003 (HY000): Can't connect to MySQL server on '127.0.0.1:3307' (61)
ERROR:
Can't connect to the server

It's ok in main branch

@leiysky
Copy link
Contributor Author

leiysky commented Jun 13, 2022

select * from t1 where a > 0 or false;

It's a bug, I've just fixed it.

@BohuTANG
Copy link
Member

The 03_0003_select_group_by failure is not related to this PR, let's merge.

@BohuTANG BohuTANG merged commit af0e36d into databendlabs:main Jun 13, 2022
@leiysky leiysky deleted the constant-folding branch June 13, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants