-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate show users/roles statement to new planner #6016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
the
pr-feature
this PR introduces a new feature to the codebase
label
Jun 16, 2022
12 tasks
junnplus
changed the title
add show users/roles statement
Migrate show users/roles statement to new planner
Jun 16, 2022
junnplus
force-pushed
the
show-users
branch
2 times, most recently
from
June 16, 2022 05:10
8c21750
to
c57b877
Compare
Need to add show in check func /// Check if statement is supported by InterpreterFactoryV2
pub fn check(stmt: &DfStatement) -> bool {
matches!(
stmt,
DfStatement::Query(_)
| DfStatement::Explain(_)
| DfStatement::CreateStage(_)
| DfStatement::ShowStages(_)
| DfStatement::DescribeStage(_)
| DfStatement::List(_)
| DfStatement::DropStage(_)
| DfStatement::RemoveStage(_)
| DfStatement::ShowDatabases(_)
| DfStatement::ShowCreateDatabase(_)
| DfStatement::ShowTables(_)
| DfStatement::ShowCreateTable(_)
| DfStatement::DescribeTable(_)
| DfStatement::ShowTablesStatus(_)
| DfStatement::CreateTable(_)
| DfStatement::CreateView(_)
| DfStatement::AlterView(_)
| DfStatement::DropTable(_)
| DfStatement::UndropTable(_)
| DfStatement::AlterTable(_)
| DfStatement::RenameTable(_)
| DfStatement::TruncateTable(_)
| DfStatement::OptimizeTable(_)
| DfStatement::DropView(_)
| DfStatement::ShowMetrics(_)
| DfStatement::ShowProcessList(_)
| DfStatement::ShowSettings(_)
| DfStatement::CreateDatabase(_)
| DfStatement::DropDatabase(_)
| DfStatement::CreateUser(_)
| DfStatement::AlterDatabase(_)
)
} |
TCeason
approved these changes
Jun 16, 2022
/lgtm |
databend-bot
approved these changes
Jun 16, 2022
Signed-off-by: Ye Sijun <junnplus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ye Sijun junnplus@gmail.com
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Summary about this PR
Changelog
Related Issues
#5777