Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): java home in build tool #6030

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

everpcpc
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

Changelog

  • Not for changelog (changelog entry is not required)

Related Issues

Fixes #issue

@vercel
Copy link

vercel bot commented Jun 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 16, 2022 at 2:05PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@everpcpc everpcpc marked this pull request as ready for review June 16, 2022 14:06
@BohuTANG BohuTANG merged commit 20d731e into databendlabs:main Jun 16, 2022
@everpcpc everpcpc deleted the fix/build branch June 16, 2022 14:49
@dantengsky
Copy link
Member

@everpcpc thanks!

but unfortunately, I missed this PR : (

Another PR

trying to fix the same docker build failure, which just
replace FOUND=$(grep -c "$1" <"${HOME}/.profile") with FOUND=$(grep -c "$1" "${HOME}/.profile" || true), so that $? will not be 1 if nothing found in the .profile.

seems these two PRs can be co-exist :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants