Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planner): migrate revoke to planner v2 #6066

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jun 20, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Changelog

  • New Feature

Related Issues

Fixes #5777

@vercel
Copy link

vercel bot commented Jun 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 20, 2022 at 0:52AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jun 20, 2022
SHOW GRANTS FOR 'test-user';
REVOKE SELECT ON b.* FROM ROLE 'test';
SHOW GRANTS FOR 'test-user';
SHOW GRANTS FOR ROLE 'test';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I think this test has some questions. But it no matters with this pr. So I will create a new issue to disscuss about it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common/ast/src/ast/statement.rs Outdated Show resolved Hide resolved
common/ast/src/ast/statement.rs Outdated Show resolved Hide resolved
common/ast/tests/it/testdata/statement.txt Show resolved Hide resolved
query/src/sql/planner/binder/ddl/account.rs Outdated Show resolved Hide resolved
@TCeason TCeason force-pushed the ISSUE-5777/revoke branch 9 times, most recently from 19ce575 to f2706ae Compare June 20, 2022 08:55
@TCeason
Copy link
Collaborator Author

TCeason commented Jun 20, 2022

@BohuTANG
test_sqllogic_standalone_macos(optional) (pull_request) failed. But test_stateless_standalone_linux (pull_request) successful.
https://github.com/datafuselabs/databend/runs/6966740715?check_suite_focus=true

It looks like the databend-query not start.

Run bash ./scripts/ci/ci-run-sqllogic-tests.sh
Starting standalone DatabendQuery and DatabendMeta
No matching processes belonging to you were found
No matching processes belonging to you were found
Start databend-query...
Waiting on databend-query 10 seconds...
Traceback (most recent call last):
not connected to :3307
  File "/Users/runner/work/databend/databend/scripts/ci/wait_tcp.py", line 32, in <module>
not connected to :3307
    tcp_ping(args.port, args.timeout)
not connected to :3307
  File "/Users/runner/work/databend/databend/scripts/ci/wait_tcp.py", line 22, in tcp_ping
not connected to :3307
    raise Exception("fail to connect to :{}".format(port))
not connected to :3307
Exception: fail to connect to :3307
not connected to :3307
not connected to :3307
not connected to :3307
not connected to :3307
not connected to :3307
Starting databend-sqllogic tests
INFO:log:run_sql_suite for mysql on base /Users/runner/work/databend/databend/tests/logictest/suites
INFO:log:Batch execute, suite name:gen/00_dummy/00_0000_dummy_select_1 in file ./suites/gen/00_dummy/00_0000_dummy_select_1
INFO:log:executing statement, type query
SELECT 1;
Traceback (most recent call last):
  File "/Users/runner/Library/Python/3.9/lib/python/site-packages/mysql/connector/network.py", line 509, in open_connection
    self.sock.connect(sockaddr)
ConnectionRefusedError: [Errno 61] Connection refused

@mergify mergify bot merged commit 0b18e39 into databendlabs:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate USER related DDL statements to new planner
4 participants