refactor(query/planner): Migrate COPY to new planner #6074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
mergify
bot
added
the
pr-feature
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
…new-planner Signed-off-by: Xuanwo <github@xuanwo.io>
|
I'm working on some cool ideas: parsed location at the parser so that we can give users more friendly error reports!
|
Signed-off-by: Xuanwo <github@xuanwo.io>
|
Oh, I like this parser! |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
@andylokandy All comments have been addressed, PTAL |
Signed-off-by: Xuanwo <github@xuanwo.io>
|
The stateful test is great 👍 |
leiysky
reviewed
Jun 21, 2022
leiysky
reviewed
Jun 21, 2022
Signed-off-by: Xuanwo <github@xuanwo.io>
andylokandy
reviewed
Jun 21, 2022
leiysky
reviewed
Jun 21, 2022
Signed-off-by: Xuanwo <github@xuanwo.io>
andylokandy
reviewed
Jun 21, 2022
Co-authored-by: Andy Lok <andylokandy@hotmail.com>
Co-authored-by: Andy Lok <andylokandy@hotmail.com>
Co-authored-by: Andy Lok <andylokandy@hotmail.com>
Co-authored-by: Andy Lok <andylokandy@hotmail.com>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
Most of the comments have been addressed. @andylokandy @leiysky PTAL. |
andylokandy
approved these changes
Jun 21, 2022
BohuTANG
approved these changes
Jun 21, 2022
BohuTANG
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
This PR will fix #5781.
There are still many works to finish, but opening a draft PR will make it much easier to track my work and give me some guidance.
Details changes
This PR implemented COPT INTO with the new planner.
Most newly added structs and functions are with comments.
Parser and ast
nomCopyTargetBinder
We used to embed
PlanNodeinCopyPlanbut it doesn't work on the new planner.So I switch to implementing
CopyPlanV2with some small changes to its layout.Interpreter
Implement
CopyInterpreterV2so that we don't afraid to break old ones.Most codes are copied from the old
CopyInterpreter.Task list
Remaining works should be addressed by #6102
Changelog