Improvement(query): fix datatype different cause mysql session distroy #6150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
fix datatype different cause mysql session distroy.
Before Sundy's pr fix #5980 NULLIF function could cause MySQL session destory.
Because in
Series::check_get(col)?;
return a err andSo should use match arm, if find the expr return Err(e) , finish the RowWriter and then return Ok(()).
BTW, we should return Ok(()) because we should not destory the session when cause these err.
Test
I has already rollback Sundy's pr and then test on my laptop. But I don't know how to test the pr on the newest commit version.
Changelog
Related Issues
Fixes #5959
#5959 (comment)