Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output of to_datetime() #6252

Merged
merged 10 commits into from
Jun 27, 2022
Merged

Fix output of to_datetime() #6252

merged 10 commits into from
Jun 27, 2022

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jun 27, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. http handler use format setting from context.
  2. Fix output precision of to_datetime()

Changelog

  • Bug Fix

Related Issues

Fixes #6245
#6244

@vercel
Copy link

vercel bot commented Jun 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jun 27, 2022 at 1:44PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 27, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Jun 27, 2022

Test failed for

--- /workspace/tests/suites/0_stateless/03_dml/03_0023_insert_into_array.result	2022-06-27 08:39:15.297518937 +0000
+++ /workspace/tests/suites/0_stateless/03_dml/03_0023_insert_into_array.stdout	2022-06-27 08:42:54.043516990 +0000
@@ -63,8 +63,8 @@
 2021-01-01	2022-01-01
 1990-12-01	2030-01-12
 ==Array(Timestamp)==
-1	['2021-01-01 01:01:01', '2022-01-01 01:01:01']
-2	['1990-12-01 10:11:12', '2030-01-12 22:00:00']
+1	['2021-01-01 01:01:01.000000', '2022-01-01 01:01:01.000000']
+2	['1990-12-01 10:11:12.000000', '2030-01-12 22:00:00.000000']
 2021-01-01 01:01:01.000000	2022-01-01 01:01:01.000000
 1990-12-01 10:11:12.000000	2030-01-12 22:00:00.000000
 ==Array(String)==
03_0023_insert_into_array_v2:                                           [ FAIL ] - result differs with:
--- /workspace/tests/suites/0_stateless/03_dml/03_0023_insert_into_array_v2.result	2022-06-27 08:39:15.297518937 +0000
+++ /workspace/tests/suites/0_stateless/03_dml/03_0023_insert_into_array_v2.stdout	2022-06-27 08:42:57.383425342 +0000
@@ -63,8 +63,8 @@
 2021-01-01	2022-01-01
 1990-12-01	2030-01-12
 ==Array(Timestamp)==
-1	['2021-01-01 01:01:01', '2022-01-01 01:01:01']
-2	['1990-12-01 10:11:12', '2030-01-12 22:00:00']
+1	['2021-01-01 01:01:01.000000', '2022-01-01 01:01:01.000000']
+2	['1990-12-01 10:11:12.000000', '2030-01-12 22:00:00.000000']
 2021-01-01 01:01:01.000000	2022-01-01 01:01:01.000000
 1990-12-01 10:11:12.000000	2030-01-12 22:00:00.000000
 ==Array(String)==

@youngsofun
Copy link
Member Author

mysql convert result to python types, which lose some detail of the results

I am writing a custom MySQLConverter to handle this.

@youngsofun
Copy link
Member Author

info: note that the toolchain 'nightly-2022-05-19-x86_64-apple-darwin' is currently in use (overridden by '/Users/runner/work/databend/databend/rust-toolchain.toml')
info: component 'rust-std' for target 'x86_64-apple-darwin' is up to date
Run cargo build --target x86_64-apple-darwin
error: failed to parse lock file at: /Users/runner/work/databend/databend/Cargo.lock
Caused by:
  package `debugid` is specified twice in the lockfile

@PsiACE
Copy link
Member

PsiACE commented Jun 27, 2022

package debugid is specified twice in the lockfile

will be fixed in #6255

@PsiACE
Copy link
Member

PsiACE commented Jun 27, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request Jun 27, 2022
@BohuTANG BohuTANG merged commit a543c75 into databendlabs:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix output fmt of timestamp
7 participants