Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): Support geo_to_h3 function #6389

Merged
merged 4 commits into from
Jul 6, 2022
Merged

feat(query): Support geo_to_h3 function #6389

merged 4 commits into from
Jul 6, 2022

Conversation

ariesdevil
Copy link
Contributor

@ariesdevil ariesdevil commented Jul 1, 2022 •
edited by BohuTANG
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Support geo_to_h3 function. Related issue #6390
FYI: H3 is a geospatial indexing system developed by Uber that partitions the world into hexagonal cells. H3 makes geo computing faster.

Changelog

  • Feature

Fixes #issue

@vercel
Copy link

vercel bot commented Jul 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 6, 2022 at 7:29AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2022

This pull request's title is not fulfill the requirements. @ariesdevil please update it 🙏.

The title should contain one if the following tags:

  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci|build: this PR changes build/testing/ci steps
  • docs|website: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@ariesdevil ariesdevil changed the title [query] Support geo_to_h3 function [feat] Support geo_to_h3 function Jul 1, 2022
@BohuTANG BohuTANG changed the title [feat] Support geo_to_h3 function feat:Support geo_to_h3 function Jul 1, 2022
@ariesdevil ariesdevil changed the title feat:Support geo_to_h3 function feat(query):Support geo_to_h3 function Jul 1, 2022
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 1, 2022
@ariesdevil
Copy link
Contributor Author

ariesdevil commented Jul 1, 2022 •
edited
Loading

@everpcpc The crate h3ron-h3-sys includes the C sources for libh3, so compiling it requires a C toolchain and the cmake build tool. We may need to install them on musl ci toolchain. Also, the clang family tool are needed.

@ariesdevil ariesdevil mentioned this pull request Jul 4, 2022
Closed
38 tasks
@Xuanwo Xuanwo changed the title feat(query):Support geo_to_h3 function feat(query): Support geo_to_h3 function Jul 5, 2022
@everpcpc everpcpc mentioned this pull request Jul 5, 2022
Merged
@ariesdevil
Copy link
Contributor Author

@Mergifyio update

zhyass
zhyass approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@zhyass zhyass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ariesdevil ariesdevil requested review from b41sh and sundy-li July 6, 2022 08:48
@BohuTANG BohuTANG merged commit f9449fa into databendlabs:main Jul 6, 2022
@ariesdevil ariesdevil deleted the dev branch July 6, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BohuTANG BohuTANG BohuTANG left review comments

@zhyass zhyass zhyass approved these changes

@b41sh b41sh Awaiting requested review from b41sh

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ariesdevil @BohuTANG @b41sh @sundy-li @zhyass