Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(planner): support mark join, (not)in/any subquery, make tpch16 and tpch18 happy #6412

Merged
merged 11 commits into from
Jul 5, 2022
Merged

feat(planner): support mark join, (not)in/any subquery, make tpch16 and tpch18 happy #6412

merged 11 commits into from
Jul 5, 2022

Conversation

xudong963
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. support mark join
  2. support (not)in subquery
  3. support ANY subquery in planner, but currently parser doesn't support ANYFeature: support ANY, ALL and Some subquery in parser #6411

Fixes #6363 #4617

@vercel
Copy link

vercel bot commented Jul 3, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 5, 2022 at 8:59AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 3, 2022
@xudong963 xudong963 marked this pull request as draft July 3, 2022 09:42
@xudong963 xudong963 mentioned this pull request Jul 4, 2022
Closed
2 tasks
@xudong963 xudong963 marked this pull request as ready for review July 4, 2022 09:34
This was referenced Jul 5, 2022
Closed
Closed
@xudong963 xudong963 requested a review from leiysky July 5, 2022 06:27
@leiysky
Copy link
Contributor

leiysky commented Jul 5, 2022

For scalar in subquery, maybe we can leverage with InFunction?

@xudong963 xudong963 mentioned this pull request Jul 5, 2022
Closed
@BohuTANG
Copy link
Member

BohuTANG commented Jul 5, 2022

Conflicting files
query/src/pipelines/new/processors/transforms/hash_join/result_blocks.rs

@xudong963
Copy link
Member Author

strange...

error: failed to get `futures` as a dependency of package `common-arrow v0.1.0 (/workspace/common/arrow)`
Caused by:
  failed to query replaced source registry `crates-io`
Caused by:
  download of fu/tu/futures failed
Caused by:
  [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Error: Process completed with exit code 101

@BohuTANG BohuTANG merged commit ff8cf56 into databendlabs:main Jul 5, 2022
@xudong963 xudong963 deleted the in_subquery branch July 5, 2022 13:59
@xudong963 xudong963 self-assigned this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiysky leiysky leiysky approved these changes

@sundy-li sundy-li Awaiting requested review from sundy-li

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees

@xudong963 xudong963

Labels
pr-feature this PR introduces a new feature to the codebase
Projects
Databend Query Planner
Status: 📕Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: support Mark join
3 participants
@xudong963 @leiysky @BohuTANG