Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): escape record_delimiter when displaying #6417

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

Veeupup
Copy link
Contributor

@Veeupup Veeupup commented Jul 3, 2022

Signed-off-by: Veeupup code@tanweime.com

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

as title, and now is:
image

Fixes #5379

Signed-off-by: Veeupup <code@tanweime.com>
@vercel
Copy link

vercel bot commented Jul 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 4, 2022 at 4:47AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2022

This pull request's title is not fulfill the requirements. @Veeupup please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^--^  ^------------^
  |     |
  |     +-> Summary in present tense.
  |
+-------> Type: feat, fix, refactor, ci, build, docs, website, chore

Valid types:

  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci|build: this PR changes build/testing/ci steps
  • docs|website: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@Veeupup Veeupup changed the title improvement: escape record_delimiter when displaying fix(query): escape record_delimiter when displaying Jul 3, 2022
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jul 3, 2022
@BohuTANG
Copy link
Member

BohuTANG commented Jul 3, 2022

The failure tests:
475
/workspace/tests/suites/0_stateless/06_show/06_0003_show_settings.sql
476
/workspace/tests/suites/0_stateless/06_show/06_0003_show_settings_v2.sql

Signed-off-by: Veeupup <code@tanweime.com>
mergify bot added a commit that referenced this pull request Jul 4, 2022
@mergify mergify bot merged commit b768847 into databendlabs:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

record_delimiter breaking the show settings
4 participants