-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce system.tables_with_history #6435
feat: introduce system.tables_with_history #6435
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There is a space at the start of the title, so our PR check always failed. I'm fixed it now. |
Roger & thanks! |
Please confirm that if |
This CI failure is due to #6418 , it's in fixing, please ignore it :) |
I haven't used |
Does this patch also fix #5858? |
no effects for this statement |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
system.tables_with_history
which contains dropped tables, and statement likeshow tables history ..
depends on itsystem.tables
no longer contains dropped tables, so that for common statements likeshow tables
(without history),call system$search_table
, no longer accesse meta data of dropped tables (which might be rather slow)To be backward compatible:
system.tables
still contains thedropped_on
columnIf it is not necessary, please let me know
NOTE:
Columns that not contained in the result set of
show full tables …
, will no longer be valid to be used in thewhere clause
ofshow tables
e.g.
show tables where table_name = “t”
no longer validshow tables like
orshow tables where Tables_in_$db = “t”
For example:
https://github.com/dantengsky/fuse-query/blob/e3730f242f36facf5a15897c735058a169cb49a2/tests/suites/0_stateless/06_show/06_0004_show_tables.sql#L17
Hope this make sense, but if any concerns, please let me know.
Fixes #6352
Fixes #5858
————————
For @flaneur2020, hope the followings will not bring too much troubles, if anything is not acceptable or should be adjusted, pls let me know.
system.tables_with_history
is addedIts schema is the same of
system.tables
show tables where table_name = …
no longer works