Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jaeger): update the doc how to use jaeger #6474

Merged
merged 1 commit into from
Jul 5, 2022
Merged

docs(jaeger): update the doc how to use jaeger #6474

merged 1 commit into from
Jul 5, 2022

Conversation

FANNG1
Copy link

@FANNG1 FANNG1 commented Jul 5, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

after #6340, "DATABEND_JAEGER" is replaced by "DATABEND_JAEGER_AGENT_ENDPOINT" , we should update the doc and show how to use it. for a newbie, may do't know how to set "DATABEND_JAEGER_AGENT_ENDPOINT"

@vercel
Copy link

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 0:46AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2022

This pull request's title is not fulfill the requirements. @sandflee please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, refactor, ci, build, docs, website, chore

Valid types:

  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci|build: this PR changes build/testing/ci steps
  • docs|website: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@PsiACE PsiACE changed the title docs(jaeger) update the doc how to use jaeger docs(jaeger): update the doc how to use jaeger Jul 5, 2022
@mergify mergify bot added the pr-doc this PR needs/changes the documents or websites label Jul 5, 2022
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BohuTANG BohuTANG merged commit 78c725c into databendlabs:main Jul 5, 2022
@FANNG1 FANNG1 deleted the jaeger branch July 5, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-doc this PR needs/changes the documents or websites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants