-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jaeger): split package to send big package to jaeger #6497
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This pull request's title is not fulfill the requirements. @sandflee please update it 🙏. Valid format:
Valid types:
|
enable auto split will impact the performance, but sending to jaeger is not enabled by default and not impact much, I think this is acceptable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but a little deeper investigation is needed
Note that if one span is too large to export, other spans within the same batch may or may not be exported. In this case, exporter will return errors as we cannot split spans.
@PsiACE , u want to know why "with_auto_split_batch" worked ? |
I am more concerned about whether we have some specific use cases that will lead to strange errors. |
I start jaeger with host network, docker run -d --network host registry-internal.corp.kuaishou.com/presto/jaegertracing, and could only show very little trace event. change OTEL_BSP_MAX_EXPORT_BATCH_SIZE not helped. |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
when using jaeger to track databend, I always see "jaeger: thrift agent failed with message too long" and set OTEL_BSP_MAX_EXPORT_BATCH_SIZE to a larger value does't take much affect. we could use "with_auto_split_batch" to split big packages.