Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(meta): refactor watch key range from [start,end] to [start,end) #6499

Merged
merged 1 commit into from
Jul 6, 2022
Merged

feat(meta): refactor watch key range from [start,end] to [start,end) #6499

merged 1 commit into from
Jul 6, 2022

Conversation

lichuang
Copy link
Contributor

@lichuang lichuang commented Jul 6, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat(meta): refactor watch key range from [start,end] to [start,end)

Fixes #issue 6485

@vercel
Copy link

vercel bot commented Jul 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 6, 2022 at 7:36AM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

This pull request's title is not fulfill the requirements. @lichuang please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^         ^---------------------^
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, refactor, ci, build, docs, website, chore

Valid types:

  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci|build: this PR changes build/testing/ci steps
  • docs|website: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@lichuang lichuang requested a review from drmingdrmer July 6, 2022 07:37
@lichuang lichuang changed the title Feature: refactor watch key range from [start,end] to [start,end) feat(meta): refactor watch key range from [start,end] to [start,end) Jul 6, 2022
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 6, 2022
mergify bot added a commit that referenced this pull request Jul 6, 2022
@mergify
Merge of #6499
236e982
@mergify mergify bot mentioned this pull request Jul 6, 2022
Closed
9 tasks
mergify bot added a commit that referenced this pull request Jul 6, 2022
@mergify
Merge of #6499
3f54481
@mergify mergify bot mentioned this pull request Jul 6, 2022
Closed
9 tasks
mergify bot added a commit that referenced this pull request Jul 6, 2022
@mergify
Merge of #6499
341ac2b
@mergify mergify bot mentioned this pull request Jul 6, 2022
Closed
9 tasks
mergify bot added a commit that referenced this pull request Jul 6, 2022
@mergify
Merge of #6499
dfcddc5
@mergify mergify bot mentioned this pull request Jul 6, 2022
Closed
9 tasks
@BohuTANG BohuTANG merged commit e890abe into databendlabs:main Jul 6, 2022
@lichuang lichuang deleted the refactor_watch branch October 26, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariesdevil ariesdevil ariesdevil approved these changes

@drmingdrmer drmingdrmer drmingdrmer approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: metasrv watch API: watching range has to be left close right open, to support prefix watch.
4 participants
@lichuang @drmingdrmer @ariesdevil @BohuTANG